fix(parameters): distinct cache key for single vs path with same name #2839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2438
Summary
This PR addresses an edge case that a customer tries to get multiple parameters by path followed by getting a single
parameter using the path name, where
GetParameterError
isn't raised in the latter due to cache.Previously reproduced as:
Changes
self.add_to_cache()
self.fetch_from_cache
to isolate getter_build_cache_key
_build_cache_key
Context
futureproofs it, but impacts readabilityis_recursive
,is_multiple
User experience
Exception raised as it should
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.