-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parser): convert functional tests to unit tests #2656
refactor(parser): convert functional tests to unit tests #2656
Conversation
|
1 similar comment
|
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2656 +/- ##
========================================
Coverage 97.23% 97.23%
========================================
Files 161 161
Lines 7426 7426
Branches 538 538
========================================
Hits 7221 7221
Misses 158 158
Partials 47 47 ☔ View full report in Codecov by Sentry. |
|
looking 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to remove functional bits into a functional test (event_parser decorator)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUPERB 🎉 🚀 🚢 🚢
Issue number: #2631
Summary
Changes
This pull request aims to enhance the test structure and organization within the parser module.
We've changed functional tests to unit tests, which makes more sense for the type of testing we're doing. Just to explain a little more, these tests specifically test whether given an event, Powertools can parser that and validate the schema.
User experience
There is no change in the user experience.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.