Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): convert functional tests to unit tests #2656

Merged
merged 30 commits into from
Jul 5, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2631

Summary

Changes

This pull request aims to enhance the test structure and organization within the parser module.

We've changed functional tests to unit tests, which makes more sense for the type of testing we're doing. Just to explain a little more, these tests specifically test whether given an event, Powertools can parser that and validate the schema.

User experience

There is no change in the user experience.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner July 4, 2023 15:59
@boring-cyborg boring-cyborg bot added the tests label Jul 4, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

⚠️Large PR detected⚠️

Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

⚠️Large PR detected⚠️

Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (51a20a3) 97.23% compared to head (4999848) 97.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2656   +/-   ##
========================================
  Coverage    97.23%   97.23%           
========================================
  Files          161      161           
  Lines         7426     7426           
  Branches       538      538           
========================================
  Hits          7221     7221           
  Misses         158      158           
  Partials        47       47           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leandrodamascena leandrodamascena added the parser Parser (Pydantic) utility label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

⚠️Large PR detected⚠️

Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.

@heitorlessa
Copy link
Contributor

looking 👀

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to remove functional bits into a functional test (event_parser decorator)

tests/unit/parser/test_alb.py Outdated Show resolved Hide resolved
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPERB 🎉 🚀 🚢 🚢

@heitorlessa heitorlessa merged commit 8617999 into aws-powertools:develop Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement parser Parser (Pydantic) utility size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: convert parser functional tests to unit test and modify the hardcoded values
4 participants