Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable Ruff rule ERA001 and fix errors #2591

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2531

Summary

Changes

Enabling Ruff rule https://beta.ruff.rs/docs/rules/commented-out-code/.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner June 27, 2023 13:01
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file jmespath JMESPath Functions utility logger metrics tests tracer Tracer utility labels Jun 27, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2023
@github-actions github-actions bot added the internal Maintenance changes label Jun 27, 2023
@leandrodamascena leandrodamascena linked an issue Jun 27, 2023 that may be closed by this pull request
@rubenfonseca
Copy link
Contributor

Great work!

@rubenfonseca rubenfonseca merged commit 9b59ba5 into aws-powertools:develop Jun 27, 2023
rafaelgsr pushed a commit to rafaelgsr/aws-lambda-powertools-python that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes jmespath JMESPath Functions utility logger metrics size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests tracer Tracer utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Ruff rule ERA001 and fix the errors
2 participants