-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): type log record in LambdaPowertoolsFormatter with TypedDict #2419
feat(logger): type log record in LambdaPowertoolsFormatter with TypedDict #2419
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2419 +/- ##
===========================================
- Coverage 97.16% 97.15% -0.02%
===========================================
Files 155 156 +1
Lines 7067 7099 +32
Branches 515 518 +3
===========================================
+ Hits 6867 6897 +30
- Misses 157 158 +1
- Partials 43 44 +1
☔ View full report in Codecov by Sentry. |
…_own_formatter example to utilize new class
Looking... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start Erika!! Made comments on how to make this change production ready, and links to help you navigate intricacies of structured typing.
Please do shout if you get stuck
Looking into this today and sending the fixes along w/ comments before merging |
I've pushed the changes to fix Mypy and bring The only unrelated change I noticed here was the THANK YOU so much for going through this change @erikayao93. Much appreciated. Changes
Unrelated changes
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
…Dict (#2419) Co-authored-by: erikayao93 <[email protected]> Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Leandro Damascena <[email protected]>
…Dict (aws-powertools#2419) Co-authored-by: erikayao93 <[email protected]> Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Leandro Damascena <[email protected]>
Issue number:
#2401
Summary
Changes
Added types.py file with TypedLog class
User experience
New typing has not been implemented into any other files, so user experience is not impacted.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.