Skip to content

Commit

Permalink
chore(logger): use package logger over source logger to reduce noise (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
heitorlessa authored Jul 22, 2024
1 parent c3de4fb commit f1357b8
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions aws_lambda_powertools/logging/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from .logger import Logger

PACKAGE_LOGGER = "aws_lambda_powertools"
LOGGER = logging.getLogger(__name__)


def copy_config_to_registered_loggers(
Expand Down Expand Up @@ -56,7 +57,7 @@ def copy_config_to_registered_loggers(
loggers = exclude
filter_func = _exclude_registered_loggers_filter

registered_loggers = _find_registered_loggers(source_logger, loggers, filter_func)
registered_loggers = _find_registered_loggers(loggers=loggers, filter_func=filter_func)
for logger in registered_loggers:
_configure_logger(source_logger=source_logger, logger=logger, level=level, ignore_log_level=ignore_log_level)

Expand All @@ -72,13 +73,12 @@ def _exclude_registered_loggers_filter(loggers: Set[str]) -> List[logging.Logger


def _find_registered_loggers(
source_logger: Logger,
loggers: Set[str],
filter_func: Callable[[Set[str]], List[logging.Logger]],
) -> List[logging.Logger]:
"""Filter root loggers based on provided parameters."""
root_loggers = filter_func(loggers)
source_logger.debug(f"Filtered root loggers: {root_loggers}")
LOGGER.debug(f"Filtered root loggers: {root_loggers}")
return root_loggers


Expand All @@ -91,12 +91,12 @@ def _configure_logger(
# customers may not want to copy the same log level from Logger to discovered loggers
if not ignore_log_level:
logger.setLevel(level)
source_logger.debug(f"Logger {logger} reconfigured to use logging level {level}")
LOGGER.debug(f"Logger {logger} reconfigured to use logging level {level}")

logger.handlers = []
logger.propagate = False # ensure we don't propagate logs to existing loggers, #1073
source_logger.append_keys(name="%(name)s") # include logger name, see #1267

for source_handler in source_logger.handlers:
logger.addHandler(source_handler)
source_logger.debug(f"Logger {logger} reconfigured to use {source_handler}")
LOGGER.debug(f"Logger {logger} reconfigured to use {source_handler}")

0 comments on commit f1357b8

Please sign in to comment.