Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove TypeInfoResolver from non AOT mode. #657

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 2, 2024

Please provide the issue number

Issue number: #656

Summary

Changes

Check if the code supports dynamic code, if it does do not add TypinfoResolver
Features are now behind RuntimeFeature.IsDynamicCodeSupported

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig October 2, 2024 14:57
@boring-cyborg boring-cyborg bot added area/common Core Powertools utility area/logging Core logging utility tests labels Oct 2, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2024
@github-actions github-actions bot added the internal Maintenance changes label Oct 2, 2024
@boring-cyborg boring-cyborg bot added the github-templates Changes in GitHub issue/PR templates label Oct 2, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2024
Copy link

sonarqubecloud bot commented Oct 2, 2024

@leandrodamascena leandrodamascena self-requested a review October 2, 2024 15:07
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.94%. Comparing base (a1275b4) to head (83ff555).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...Logging/Serializers/PowertoolsLoggingSerializer.cs 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #657      +/-   ##
===========================================
- Coverage    72.99%   72.94%   -0.05%     
===========================================
  Files          195      196       +1     
  Lines         7998     8013      +15     
  Branches       854      856       +2     
===========================================
+ Hits          5838     5845       +7     
- Misses        1874     1878       +4     
- Partials       286      290       +4     
Flag Coverage Δ
unittests 72.94% <77.77%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca merged commit 4ab0fea into aws-powertools:develop Oct 2, 2024
7 of 8 checks passed
@hjgraca hjgraca deleted the fix(logging)-typeinforesolver-non-aot branch October 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/common Core Powertools utility area/logging Core logging utility github-templates Changes in GitHub issue/PR templates internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Enum logging throws NotSupportedException and empty log entry when running under .net8
2 participants