-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Tracing add AOT support #607
Conversation
…d remove aspecthandler. refacor tests, still need to fix test runner issues
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #607 +/- ##
===========================================
- Coverage 72.44% 72.41% -0.03%
===========================================
Files 190 190
Lines 7897 7874 -23
Branches 852 850 -2
===========================================
- Hits 5721 5702 -19
+ Misses 1888 1878 -10
- Partials 288 294 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…a-dotnet into aot-tracing-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Henrique Graca <[email protected]>
…a-dotnet into aot-tracing-support
|
Issue number: #212
Summary
Tracing support for AOT
Changes
Remove dependency from UniversalWrapperAspect.cs and refactor Tracing attribute/decorator
.NET8 specific paths in code
Refactor TracingAttributeTest.cs no more mocks
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.