Skip to content

Conversation

@hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Mar 13, 2024

Please provide the issue number

Issue number: #212

Summary

Update docs to make clear we support .NET 6 and .NET 8

Changes

Update docs

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig March 13, 2024 20:11
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2024
@github-actions github-actions bot added the internal Maintenance changes label Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (9288404) to head (b2c6988).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #569      +/-   ##
===========================================
- Coverage    72.95%   72.33%   -0.63%     
===========================================
  Files          109      109              
  Lines         4489     4489              
  Branches       455      455              
===========================================
- Hits          3275     3247      -28     
- Misses        1085     1107      +22     
- Partials       129      135       +6     
Flag Coverage Δ
unittests 72.33% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hjgraca added 2 commits March 13, 2024 20:15
Signed-off-by: Henrique Graca <[email protected]>
Signed-off-by: Henrique Graca <[email protected]>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirkaws amirkaws merged commit 02db37e into develop Mar 15, 2024
@amirkaws amirkaws deleted the hjgraca-update-docs-dotnet8 branch March 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants