Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameters nuget icon #271

Merged
merged 2 commits into from
May 15, 2023
Merged

fix: parameters nuget icon #271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cb63ea
fix parameters nuget icon
amirkaws May 12, 2023
7c6df53
remove the version change
amirkaws May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions libraries/src/AWS.Lambda.Powertools.Parameters/AWS.Lambda.Powertools.Parameters.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,45 @@
<TargetFramework>net6.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<LangVersion>default</LangVersion>
<PackageId>AWS.Lambda.Powertools.Parameters</PackageId>
<Version>0.0.1</Version>
<Authors>Amazon Web Services</Authors>
<Company>Amazon.com, Inc</Company>
<Title>AWS Lambda Powertools for .NET</Title>
<Description>AWS Lambda Powertools for .NET - Parameters package.</Description>
<Copyright>Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.</Copyright>
<RepositoryUrl>https://github.com/awslabs/aws-lambda-powertools-dotnet</RepositoryUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<PackageTags>AWS;Amazon;Lambda;Powertools</PackageTags>
<PackageReadmeFile>README.md</PackageReadmeFile>
<PackageIconUrl>https://sdk-for-net.amazonwebservices.com/images/AWSLogo128x128.png</PackageIconUrl>
<PackageIcon>AWSLogo128x128.png</PackageIcon>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<AssemblyName>AWS.Lambda.Powertools.Parameters</AssemblyName>
<RootNamespace>AWS.Lambda.Powertools.Parameters</RootNamespace>
</PropertyGroup>

<PropertyGroup>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\AWS.Lambda.Powertools.Common\AWS.Lambda.Powertools.Common.csproj" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.103.1" />
<PackageReference Include="AWSSDK.SecretsManager" Version="3.7.102.38" />
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.104.29" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
<None Include="README.md" Pack="true" PackagePath="\" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\AWS.Lambda.Powertools.Common\AWS.Lambda.Powertools.Common.csproj" />
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.103.1" />
<PackageReference Include="AWSSDK.SecretsManager" Version="3.7.102.38" />
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.104.29" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
</ItemGroup>

<ItemGroup>
<None Include="../../AWSLogo128x128.png" Pack="true" Visible="false" PackagePath="" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"Tracing": "1.1.0"
},
"Utilities": {
"Parameters": "0.0.1-preview"
"Parameters": "0.0.2-preview"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the version? There are no code changes. If we push to nuget does it not update if the version is there already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say so

Copy link
Contributor Author

@amirkaws amirkaws May 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a change in dll metadata at least, we are deploying a new NuGet package, and our deployment are immutable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the version change, icon will be fixed with next release.

}
}