Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use success() condition in the soak workflow #345

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Nov 8, 2022

Description:

This PR is created to use success()s instead of failure(). The reason for this change is that it is not necessary to check the ancestors jobs, which would lead not getting o/p layer ARNeven when succeed in re-runs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vasireddy99 vasireddy99 requested a review from a team as a code owner November 8, 2022 19:59
@@ -251,7 +253,7 @@ jobs:
-a ${{ matrix.architecture }}
- name: Set output if layer Soak Tests has error
id: set-layer-if-error-output
if: ${{ failure() }}
if: ${{ success() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the official documentation for success() existing? I have found the docs for failure().

Also, can you expand why this change is necessary? From what I can see this step only needs to happen if a previous step fails, not if it is successful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, found the docs for success() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah added the description for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we want to run echo "::set-output name=${{ matrix.language }}-${{ matrix.instrumentation-type }}-error::FAILED" if the previous steps were successful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think i could improve this PR.

@vasireddy99 vasireddy99 marked this pull request as draft November 9, 2022 06:59
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale label Jan 8, 2023
@vasireddy99 vasireddy99 removed the stale label Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

This PR is stale because it has been open 60 days with no activity.

Copy link

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants