feat: Add Contract Tests for new Gen AI attributes for foundational models #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: set up gen ai inference attributes for foundational text models…
- added contract tests for amazon titan and anthropic claude models - added support to compare float attributes
|
Contract test case failing in workflow. Could you help take a look? |
oh the only contract test failing is the cohere_command_r model which should work once your PR goes through @yiyuan-he |
Sounds good, thanks for confirming! |
yiyuan-he
approved these changes
Nov 21, 2024
mxiamxia
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
contract tests for new gen_ai inference parameter added in
e8c96ae#diff-20c2ca1cb28cda6e03ec0cb986933b2abd103bee39995ad232cc2e8c2d23e4aaR368
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.