Add design doc for collector processor experience #41
Conversation
anuraaga
force-pushed
the
collector-processor-design
branch
from
7df485e
to
7a3a013
Compare
|
|
||
| The processors implementing this use case are `metricsgenerationprocessor`, `spanmetricsprocessor`. | ||
|
|
||
| ### Grouping |
There was a problem hiding this comment.
Should cumulative to delta and delta to rate be included here?
| telemetry signal. For metrics, the structure presented for processing is actual data points, e.g. `NumberDataPoint`, | ||
| `HistogramDataPoint`, with the information from higher levels like `Metric` or the data type available as virtual fields. | ||
|
|
||
| Navigation can then be used with a simple expression language for identifying telemetry to operate on. |
There was a problem hiding this comment.
Is this expression language designed from scratch or is it a specialization of some existing language to our domain? Is there a formal grammar?
|
|
||
| ``` | ||
| create_histogram("duration", end_time_nanos - start_time_nanos) where type = span | ||
| keep(attributes, "http.method") where type = metric and descriptor.metric_name = "duration |
There was a problem hiding this comment.
| keep(attributes, "http.method") where type = metric and descriptor.metric_name = "duration | |
| keep(attributes, "http.method") where type = metric and descriptor.metric_name = "duration" |
| keep(attributes, "http.method") where type = metric and descriptor.metric_name = "duration | ||
| ``` | ||
|
|
||
| Group spans by trace ID |
There was a problem hiding this comment.
What does this do? I.e., are the grouped traces aggregated in some way or dumped out as Pair<TraceId, List<Span>>? What does the 2m do?
|
|
||
| ## Declarative configuration | ||
|
|
||
| The telemetry query language presents an SQL-like experience for defining telemetry transformations - it is made up of |
There was a problem hiding this comment.
A syntax even closer to SQL would be more familiar/approachable to many potential users. It may be worth documenting why we're considering a custom syntax instead.
|
Tangentially, I've researched this topic and have a prototype I'm trying to extract from Google, see my plea: https://gist.github.com/jmacd/17a6f2885d92d7864ba76680a8ee367a |
No description provided.