Skip to content

chore: Pin ECS module to sha while module is undergoing changes #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2023
Merged

chore: Pin ECS module to sha while module is undergoing changes #130

merged 3 commits into from
Apr 3, 2023

Conversation

@bryantbiggs
Copy link
Contributor

Description

  • Pin ECS module to sha while module is undergoing changes

Motivation and Context

  • The current module source is pointed at a fork that is undergoing changes based on PR review feedback. This will pin the source to a stable version to avoid user disruption. Once the upstream PR is merged a separate PR will be opened to remove the fork source and instead use a versioned upstream source. The SHA used is from March 13th prior to latest changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from a team as a code owner April 3, 2023 14:39
@bryantbiggs
Copy link
Contributor Author

works locally with ref to SHA, squashing as is

@bryantbiggs bryantbiggs merged commit 5497613 into main Apr 3, 2023
@bryantbiggs bryantbiggs deleted the chore/pin-module branch April 3, 2023 23:31
@bryantbiggs bryantbiggs mentioned this pull request Apr 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nvpnathan nvpnathan nvpnathan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryantbiggs @nvpnathan