Fixed the Python version issue and update the quickstart URLs

[rahul188]

I created a PR to fix the Python version issue and update the quickstart URLs. This resolves the following issues:

Issue #28
Issue #20
Issue #13

[sshvans]

@rahul188 Instead of updating automation script, pls add the ignore checks in the template.

[rahul188]

@sshvans i have made changes in templates.

[rahul188]

@sshvans can you take a look on this? as its customer is waiting for this fix.

[sshvans]

/do-e2e-tests

[aws-ia-automator-prod]

End to end test has been scheduled

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

[rahul188]

@sshvans , can you please elaborate the failure?

[sshvans]

@rahul188 It uses following 3 parameters to deploy the stack. Currently, the test is failing bcz these values are missing in the config file that is stored internally and used while testing the templates. Can you provide these values over email that can be stored and used for testing?
NewRelicAccountNumber: ''
LaunchAccountList: ''
NewRelicAccessKey: ''

[rahul188]

@sshvans, For testing purposes, to avoid security hiccups please create a new free New Relic account and provide the following values to update the config file:

• NewRelicAccountNumber
• NewRelicAccessKey

Additionally, could you also provide more information on what values should be populated for the LaunchAccountList variable?

[tbulding]

/do-e2e-tests

[aws-ia-automator-prod]

End to end test has been scheduled

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

[rahul188]

@tbulding , can you give us more insights.

[tbulding]

Please add the additional parameters to your TaskCat test file...

      AdditionalParametersLicenseKey: ''
      NewRelicLicenseKey: ''

Template validation for these templates is failing with errors due to number of characters (32 instead of 40). Additionally the Regex Pattern is reporting false positives when I modified them in my test environment. I changed the pattern from

'^([A-Z0-9-]){32}$'
to 
'^[A-Za-z0-9]{40}$'

templates/control-tower-customization.template.yml
templates/newrelic-hub-cfct.yaml

After making these modifications in my test environment, The test started, however it failed when creating the custom resource. Here are the error details...

"
"StackName": "tCaT-cfn-ps-ct-newrelic-one-newrelic-onboarding",
"LogicalResourceId": "NewRelicFirstLaunch",
"PhysicalResourceId": "tCaT-cfn-ps-ct-newrelic-one-newrelic-onboarding-us-west-2-...",
"ResourceType": "AWS::CloudFormation::CustomResource",
"Timestamp": "2024-08-09T17:21:42.851000+00:00",
"ResourceStatus": "CREATE_FAILED",
"ResourceStatusReason": "Received response status [FAILED] from custom resource. Message returned: ERROR: (truncated) xist\nFor more information check ...
(Service: AmazonCloudFormation; Status Code: 400; Error Code: ValidationError; Request ID: ...; Proxy: null) (RequestId: ...)",
"ResourceProperties": "{\"ServiceToken\":\"arn:aws:lambda:us-west-2:...:function:tCaT-cfn-ps-ct-newrelic-o-NewRelicOnboardingFuncti-...\"}"

[rahul188]

@tbulding the above failure with status code 400 due to StackSetUrl which present in .taskcat.yml file was not accessible. i have updated the same StackSetUrl which is present in control-tower-customization.template.yml file and now its woking as expected.

[tbulding]

/do-e2e-tests

[aws-ia-automator-prod]

End to end test has been scheduled

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

[tbulding]

Please update the constraint restrictions for the Access Key in these files.
^([A-Z0-9-]){32}$
^([A-Z0-9-]){32}$

[tbulding]

/do-e2e-tests

[aws-ia-automator-prod]

End to end test has been scheduled

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

[tbulding]

/do-e2e-tests

[aws-ia-automator-prod]

End to end test has been scheduled

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E tests completed successfully

[motske]

I know this was merged already, but I think there is an issue with commit d104340 . This changed the NewRelicAccessKey requirement from 32 to 40 character for NewRelicAccessKey, but I think 32 is the correct value. NewRelic 'Ingest - License' keys are 40 characters, but my 'NerdGraph User' keys all seem to be 32 characters. I created a new User key today and it was 32 characters including the NRAK prefix and the '-' character.

Should I create a new issue or would @rahul188 like to address this?