First version of trend-cloudone-onboard. #2
Conversation
|
Hi there, I am commenting because your project has not yet been published and you have opened a pr to the If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
If you require more information please reach out to your AWS PoC who is assisting you with this project. |
Removing unused submodule
Added a script to generate Zips from Source folder.
Updating taskcat config to build the zips. Adjust the prefix and change. TemplateURLs as a consequence.
Add comments with explanations on using external templates.
lambda_functions/source/GetCloudOneRegionAndAccountFunction/app.py
Outdated
Show resolved
Hide resolved
lambda_functions/source/AWSConnectorCreateLambda/requirements.txt
Outdated
Show resolved
Hide resolved
templates/trend-cloudone-onboard/workloadsecurity.template.yaml
Outdated
Show resolved
Hide resolved
|
/do-e2e-tests |
|
Checks must all be completed successfully before end to end testing can be run. |
|
/confirm-publication |
Removing crhelper. Creating KMS and Secrets. Utilizing secrets instead of plaintext for confidential data. Minor fixes. Response to PR comments.
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
e2e test in progress |
![aws-ia-automator-gamma[bot]](https://avatars.githubusercontent.com/u/124853050?s=60&v=4){kind=small}
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
e2e test in progress |
Altough I was able to run
taskcatto test it locally, I wasn't able to properly runash, and I still have multiple questions.Questions
ash?taskcatexecution? There are two parameters that are secrets unique to a customer, I wonder how we can then test this in GitHub Actions.lambdas/folder as well?