Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging in initial templates for taskcat functional test debugging #1

Merged
merged 14 commits into from
May 15, 2023
Merged

Merging in initial templates for taskcat functional test debugging #1

merged 14 commits into from
May 15, 2023

Conversation

ZacharyWallace
Copy link
Collaborator

THIS PR IS A WIP/FOR DEBUGGING

  • Created logging-top-level.yaml as entry point
  • Created nested template setup-logging-role for IAM role/policy creation
  • Added submodules for GuardDuty and CloudTrail
  • Setup .taskcat.yaml for functional testing

Currently receiving errors in GuardDuty submodule around creation of lambda service-linked roles in new ControlTower environment

@aws-ia-automator-gamma
Copy link
Contributor

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.
If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are
not ready to publish yet, we recommend you close this PR and develop against a different branch.
Once you are ready to publish you can open a PR from that branch to main.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS PoC who is assisting you with this project.

@ZacharyWallace ZacharyWallace reopened this May 4, 2023
@kkvinjam
Copy link
Collaborator

kkvinjam commented May 9, 2023

/do-e2e-tests

@aws-ia-automator-gamma
Copy link
Contributor

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link
Contributor

e2e test in progress

aws-ia-automator-gamma[bot]
aws-ia-automator-gamma bot requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-gamma
Copy link
Contributor

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link
Contributor

e2e test in progress

aws-ia-automator-gamma[bot]
aws-ia-automator-gamma bot requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-gamma
Copy link
Contributor

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link
Contributor

e2e test in progress

aws-ia-automator-gamma[bot]
aws-ia-automator-gamma bot requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-gamma
Copy link
Contributor

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link
Contributor

e2e test in progress

aws-ia-automator-gamma[bot]
aws-ia-automator-gamma bot previously approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests completed successfully

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-gamma
Copy link
Contributor

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link
Contributor

e2e test in progress

aws-ia-automator-gamma[bot]
aws-ia-automator-gamma bot approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests completed successfully

@kkvinjam kkvinjam merged commit 8c1f5ed into aws-ia:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-ia-automator-gamma aws-ia-automator-gamma[bot] aws-ia-automator-gamma[bot] approved these changes

@kkvinjam kkvinjam kkvinjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacharyWallace @kkvinjam