handle IPC call errors and bubble them up #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrzhan
previously approved these changes
Apr 3, 2025
kstribrnAmzn
reviewed
Apr 3, 2025
| @@ -641,7 +653,7 @@ GglError runner(const RecipeRunnerArgs *args) { | |||
| } | |||
| default: | |||
| GGL_LOGE("Failed to get noProxyAddresses from config."); | |||
| return ret; | |||
| break; | |||
There was a problem hiding this comment.
Similar comment as above. One additional question - what happens if the proxy URL is set but the noProxyAddress value is not set?
archigup
reviewed
Apr 3, 2025
archigup
reviewed
Apr 3, 2025
archigup
reviewed
Apr 3, 2025
archigup
reviewed
Apr 3, 2025
archigup
requested changes
Apr 3, 2025
kstribrnAmzn
reviewed
Apr 4, 2025
bins/ggipcd/src/services/config/subscribe_to_configuration_update.c
Outdated
Show resolved
Hide resolved
bins/ggipcd/src/services/config/subscribe_to_configuration_update.c
Outdated
Show resolved
Hide resolved
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
bins/ggipcd/src/services/config/subscribe_to_configuration_update.c
Outdated
Show resolved
Hide resolved
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
bins/ggipcd/src/services/config/subscribe_to_configuration_update.c
Outdated
Show resolved
Hide resolved
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
archigup
reviewed
Apr 4, 2025
This commit however is not complete on it's own. Even though the server is sending the error codes, the client does not yet understand them. There will be a fast follow up PR for updating the client. There are a couple of TODOs added to the code which will be removed once the client starts to process the incoming error codes sent by the IPC server.
archigup
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR modifies the IPC client to handle the call errors more gracefully and bubble up the errors to the caller.
Supersedes #830.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.