Skip to content

updating operator-sdk to 1.28.0#348

Merged
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
acornett21:update_operator_sdk
May 16, 2023
Merged

updating operator-sdk to 1.28.0#348
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
acornett21:update_operator_sdk

Conversation

@acornett21
Copy link
Copy Markdown
Contributor

Issue #, if available:
N/A

Description of changes:
Updating to use 1.28.0 of operator-sdk

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@jaypipes
Copy link
Copy Markdown
Collaborator

/lgtm

@ack-prow ack-prow bot added the approved label May 16, 2023
@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit a522521 into aws-controllers-k8s:main May 16, 2023
@acornett21
Copy link
Copy Markdown
Contributor Author

@jaypipes Doesn't someone have to still build/push these images? Or are container updates now automatic?

@jaypipes
Copy link
Copy Markdown
Collaborator

@jaypipes Doesn't someone have to still build/push these images? Or are container updates now automatic?

@acornett21 I believe @RedbackThomson will need to repush the images? but maybe they are automatic now....

@RedbackThomson RedbackThomson mentioned this pull request May 17, 2023
ack-prow bot pushed a commit that referenced this pull request Jun 12, 2023
Description of changes:
Updates the OLM images to include the latest changes from #348

Note: I have changed the format of the images to use the short commit SHA as the primary identifier, since it's a more useful indicator of the contents of the images compared to an arbitrary semver. This is the default behaviour if no `VERSION` var is passed to `./push-image`.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants