Fix controller shutdown status patching with a fresh context for patches

[rushmash91]

Fixes: aws-controllers-k8s/community#2497, aws-controllers-k8s/community#2103

Description of changes:

During controller shutdown (SIGTERM), status updates were failing because patchResourceStatus was attempting to patch using the original cancelled context. This resulted in resources not having their final status properly updated in the resource manifest, leaving them in an inconsistent state.

FIX: Always use context.WithoutCancel(ctx) for all patch operations to prevent cancellation propagation while preserving context values. The 30s SIGTERM grace period serves as the effective timeout, eliminating the need for additional timeout logic that could interfere with normal Kubernetes client timeout/retry strategy.

Changes:

Created util functions:

- patchWithoutCancel()
- patchStatusWithoutCancel() 

Operations updated to Use context.WithoutCancel(ctx)
Main Reconciler:

- patchResourceMetadataAndSpec()
- patchResourceStatus()

Adoption Reconciler:

- patchMetadataAndSpec()
- patchStatus()

Field Export Reconciler:

- patchMetadataAndSpec()
- patchStatus()
- writeToConfigMap()
- writeToSecret()

eg logs:

{"level":"debug","ts":"2025-06-05T09:52:16.723-0700","logger":"ackrt","msg":"< r.Sync","kind":"Policy","namespace":"default","name":"iiobalic90","account":"xx","role":"","region":"us-west-2","is_adopted":false,"generation":1,"error":"operation error IAM: GetPolicy, context canceled"}
{"level":"info","ts":"2025-06-05T09:52:16.723-0700","logger":"ackrt","msg":"created patch context with timeout","kind":"Policy","namespace":"default","name":"iiobalic90","account":"xx","role":"","region":"us-west-2","is_adopted":false,"generation":1,"timeout_seconds":10}
{"level":"debug","ts":"2025-06-05T09:52:16.723-0700","logger":"ackrt","msg":"> r.patchResourceStatus","kind":"Policy","namespace":"default","name":"iiobalic90","account":"xx","role":"","region":"us-west-2","is_adopted":false,"generation":1}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[knottnt]

Can we add a test for this behavior?

[rushmash91]

/retest

[rushmash91]

/test ec2-controller-test

[ack-prow]

@rushmash91: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test ec2-controller-test
• /test ecr-controller-test
• /test iam-controller-test
• /test s3-controller-test
• /test sagemaker-controller-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test verify-attribution

Use /test all to run all jobs.

In response to this:

/retest s3-controller-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rushmash91]

/test s3-controller-test

[rushmash91]

/test ec2-controller-test

[rushmash91]

/hold

[a-hilaly]

nice, thanks @rushmash91 !

[rushmash91]

/unhold

[a-hilaly]

Great job @rushmash91 !
/lgtm

[a-hilaly]

/retest

[ack-prow]

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
verify-attribution	21f3a8b	link	false	/test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[a-hilaly]

/lgtm

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly,knottnt,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rushmash91]

/test ec2-controller-test