Skip to content

Conversation

@michaelhtm
Copy link
Member

Description of changes:
Extra changes:

  • Ensure lateInitialize is not called for readOnly policy
  • Add mock call for PopulateResourceFromAnnotation in adopt tests
  • Ensure FilterSystemTags is called for adopt policy

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 May 19, 2025 21:30
@ack-prow ack-prow bot added the approved label May 19, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelhtm !

Comment on lines +492 to +493
} else if isReadOnly {
return latest, nil
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Extra changes:
* Ensure lateInitialize is not called for readOnly policy
* Add mock call for PopulateResourceFromAnnotation in adopt tests
* Ensure FilterSystemTags is called for `adopt` policy
@michaelhtm michaelhtm force-pushed the fix/enablefeaturegatesfortests branch from ef93ee4 to 9a073ca Compare May 23, 2025 18:36
@ack-prow
Copy link

ack-prow bot commented May 23, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 9a073ca link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@ack-prow
Copy link

ack-prow bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 6a1bc57 into aws-controllers-k8s:main Jun 16, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants