Skip to content

Conversation

@a-hilaly
Copy link
Member

Introduces label selectors to filter which objects controllers watch, reducing resource usage
and improving performance in large clusters by allowing controllers to focus only on objects
with specific labels instead of processing all resources.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from jlbutler March 27, 2025 00:56
@ack-prow ack-prow bot added the approved label Mar 27, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 27, 2025

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 69d450c link false /test verify-attribution
sagemaker-controller-test 69d450c link true /test sagemaker-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@rushmash91 rushmash91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @itaiatu and @a-hilaly !!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rushmash91 rushmash91 merged commit 07dcd40 into aws-controllers-k8s:main Mar 27, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants