Enhance EKS AccessEntries policy attachements and delta logic
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
added
the
do-not-merge/work-in-progress
ack-prow
bot
added
approved
and removed
do-not-merge/work-in-progress
|
/lgtm |
|
/retest |
Prior to this patch, we observed some issues with the controller behaviour regarding access policy association and delta computations, specifically: - False positive deltas were detected at every reconciliation (or controller restart) - When a delta was detected, the controller disociate the latest policies, and patch the desired ones. (Even when it's unnecessary). The root cause was identifier as the usage of `reflect.DeepEqual` for slices. According to the `reflect` library documentation https://pkg.go.dev/reflect#DeepEqual `DeepEqual` returns false if the comapred elements are a nil slice and a "non-nil empty slice" (e.g `nil` and `[]string{}`). This combined with the possibility of a user providing a nil `namespaces` slice, while the controller sets an empty one (based on the API response), cause behaviour inconsistencies. Users shouldn't care/worry about the "nil-ity" of their arrays/slices; it is up to the controller to accurately compute the deltas. This patch replaces the usage of `reflect.DeepEqual` with a meticulous custom delta function. Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
accessentries
branch
from
36f225a to
5970d4c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, we observed some issues with the controller
behaviour regarding access policy association and delta computations,
specifically:
controller restart)
policies, and patch the desired ones. (Even when it's unnecessary).
The root cause was identifier as the usage of
reflect.DeepEqualforslices. According to the
reflectlibrary documentationDeepEqualreturns false if the comapred elements are a nil slice anda "non-nil empty slice" (e.g
niland[]string{}).This combined with the possibility of a user providing a nil
namespacesslice, while the controller sets an empty one (based on theAPI response), cause behaviour inconsistencies.
Users shouldn't care/worry about the "nil-ity" of their arrays/slices;
it is up to the controller to accurately compute the deltas.
This patch replaces the usage of
reflect.DeepEqualwith a meticulouscustom delta function.
Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.