fix: ensure we check the latest resource for status #35
Conversation
|
/retest |
Currently we have been checking the desired status in post_set_output. At that point the desired resource will not have been updated with the latest Status from the describe output, leading the controller to be in an endless reconciliation loop
michaelhtm
force-pushed
the
fix/reconcile
branch
from
b118790 to
1e9a8d6
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #2180
Description of changes:
Currently we have been checking the desired status in post_set_output.
At that point the desired resource will not have been updated with the
latest Status from the describe output, leading the controller to be in
an endless reconciliation loop
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.