Skip to content

Generated with GoV2 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ack-prow merged 1 commit into from
Feb 5, 2025
Merged

Generated with GoV2 #26

ack-prow merged 1 commit into from
Feb 5, 2025

Conversation

@rushmash91
Copy link
Contributor

@rushmash91 rushmash91 commented Jan 27, 2025

Issue #, if available:

Description of changes:
Update controller to support GoV2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm January 27, 2025 19:28
@rushmash91
Copy link
Contributor Author

rushmash91 commented Jan 27, 2025

/test efs-kind-e2e

1 similar comment
@rushmash91
Copy link
Contributor Author

rushmash91 commented Jan 27, 2025

/test efs-kind-e2e

@rushmash91 rushmash91 force-pushed the main branch 14 times, most recently from a7d21fe to 165a6a3 Compare January 30, 2025 21:39
@rushmash91 rushmash91 force-pushed the main branch 3 times, most recently from 0aeddb0 to cde23cd Compare February 4, 2025 22:40
@michaelhtm michaelhtm force-pushed the main branch 2 times, most recently from bc3f2dd to 70c97c3 Compare February 5, 2025 19:13
michaelhtm
michaelhtm approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding off release of this one as well
/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Feb 5, 2025
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@ack-prow
Copy link

ack-prow bot commented Feb 5, 2025 •
edited
Loading

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
efs-verify-attribution da995b9 link false /test efs-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

michaelhtm commented Feb 5, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@ack-prow
Copy link

ack-prow bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 8929330 into aws-controllers-k8s:main Feb 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@michaelhtm michaelhtm

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rushmash91 @michaelhtm