Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 9, 2024

Update to ACK runtime v0.40.0, code-generator v0.40.0



NOTE:
This PR increments the release version of service controller from v1.0.1 to v1.0.2

Once this PR is merged, release v1.0.2 will be automatically created for efs-controller

Please close this PR, if you do not want the new patch release for efs-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building efs-controller ====
Copying common custom resource definitions into efs
Building Kubernetes API objects for efs
Generating deepcopy code for efs
Generating custom resource definitions for efs
Building service controller for efs
Generating RBAC manifests for efs
Running gofmt against generated code for efs
Updating additional GitHub repository maintenance files
==== building efs-controller release artifacts ====
Building release artifacts for efs-v1.0.2
Generating common custom resource definitions
Generating custom resource definitions for efs
Generating RBAC manifests for efs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Dec 9, 2024
@ack-prow ack-prow bot requested a review from a-hilaly December 9, 2024 17:36
@ack-prow
Copy link

ack-prow bot commented Dec 9, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
efs-verify-attribution 9f08988 link false /test efs-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@ack-prow
Copy link

ack-prow bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 14, 2025
@ack-prow ack-prow bot merged commit 1c88bdc into main Jan 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants