Skip to content

chore(v1.2.1): create new release #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ack-prow merged 1 commit into from
Jan 18, 2024
Merged

chore(v1.2.1): create new release #175

ack-prow merged 1 commit into from
Jan 18, 2024
+5 −5

Conversation

@vflaux
Copy link
Contributor

@vflaux vflaux commented Jan 18, 2024

Merged PRs since last release:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2024
@ack-prow
Copy link

ack-prow bot commented Jan 18, 2024

Hi @vflaux. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vflaux vflaux marked this pull request as ready for review January 18, 2024 11:07
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@ack-prow ack-prow bot requested a review from jljaco January 18, 2024 11:07
@a-hilaly
Copy link
Member

a-hilaly commented Jan 18, 2024

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2024
a-hilaly
a-hilaly approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@ack-prow
Copy link

ack-prow bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, vflaux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 18, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Jan 18, 2024

Need to hold this for a bit, until we have a fix for the release pipeline.
/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Jan 18, 2024

/retest

1 similar comment
@a-hilaly
Copy link
Member

a-hilaly commented Jan 18, 2024

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Jan 18, 2024

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Jan 18, 2024

/retest

@ack-prow ack-prow bot merged commit 1122aa5 into aws-controllers-k8s:main Jan 18, 2024
nnbu pushed a commit to nnbu/ack-ec2-controller that referenced this pull request Sep 18, 2024
@vflaux
chore(v1.2.1): create new release (aws-controllers-k8s#175)
5b92b7c 
Merged PRs since last release:
- aws-controllers-k8s#165
- aws-controllers-k8s#174

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@LikithaVemulapalli LikithaVemulapalli Awaiting requested review from LikithaVemulapalli

@jljaco jljaco Awaiting requested review from jljaco

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vflaux @a-hilaly