Skip to content

chore(v1.2.0): create new release#173

Merged
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
marcdavoli:chore(v1.2.0)/create-new-release
Jan 4, 2024
Merged

chore(v1.2.0): create new release#173
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
marcdavoli:chore(v1.2.0)/create-new-release

Conversation

@marcdavoli
Copy link
Contributor

@marcdavoli marcdavoli commented Jan 4, 2024

Merged PRs since last release:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Jan 4, 2024

Hi @marcdavoli. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2024
a-hilaly
a-hilaly approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Jan 4, 2024

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2024
@ack-prow
Copy link

ack-prow bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, marcdavoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 4, 2024
@ack-prow ack-prow bot merged commit 3ac4413 into aws-controllers-k8s:main Jan 4, 2024
nnbu pushed a commit to nnbu/ack-ec2-controller that referenced this pull request Sep 18, 2024
@marcdavoli
chore(v1.2.0): create new release (aws-controllers-k8s#173)
80212e3 
Merged PRs since last release:
- aws-controllers-k8s#167 
- aws-controllers-k8s#168 
- aws-controllers-k8s#172 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@LikithaVemulapalli LikithaVemulapalli Awaiting requested review from LikithaVemulapalli

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcdavoli @a-hilaly