Fix AdoptedResource functionality for FlowLogs

[nnbu]

Issue # : aws-controllers-k8s/community#1946

RCA:
Following CR currently fails to adopt the existing FlowLog resource.

apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
  name: flowlog1
spec:
  aws:
    nameOrID: fl-xxxxxx
  kubernetes:
    group: ec2.services.k8s.aws
    kind: FlowLog
    metadata:
      name: flowlog-adopted
      namespace: default

The error

"error": "FlowLog.ec2.services.k8s.aws "my-resource" is invalid: [spec.resourceID: Required value, spec.resourceType: Required value]"}

comes from https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/adoption_reconciler.go#L157

SetIdentifiers function needs to have code to fill up required values of the CR so as to solve this issue.

Solution:
2 new fields are defined as resourceID and resourceType and they are initialized in SetIdentifiers function. These fields need to part of additionalKeys field of AdoptedResource CR for FlowLog.

The new CR looks like,

apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
  name: flowlog1
spec:
  aws:
    nameOrID: fl-xxxxx
    additionalKeys:
      resourceID: vpc-xxxxxx
      resourceType: VPC
  kubernetes:
    group: ec2.services.k8s.aws
    kind: FlowLog
    metadata:
      name: flowlog-adopted
      namespace: default

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @nnbu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/ok-to-test

[nnbu]

@a-hilaly Could you please review this? I have addressed the comments

[a-hilaly]

Thank you, @nnbu !
/lgtm

[a-hilaly]

/hold

[a-hilaly]

/unhold

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, nnbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment