feat: add support for VPCEndpointServiceConfiguration CRD

[cannonpalms]

Issue #, if available: aws-controllers-k8s/community#1711

Description of changes: Essentially just recreates #134 but with the benefit of hindsight; this PR does not touch RouteTable CRDs, as the former did. It would seem that the problems resulting from this issue may have been solved, thus rendering us ready to rock.

@jaypipes Would you mind telling me if I've made a poor assumption somewhere? I see in the upstream issue about nested lists that @RedbackThomson was originally slated to work on it. I didn't see any linked PRs to that issue, however, when rebuilding #134 from scratch, I did not need to modify the RouteTable CRD to work around this issue, so perhaps it has been fixed?

Either way, we would love to get this upstreamed. I'd separately love it if someone could comment on the general safety of using a build based off of this PR in production just to gain access to VPCEndpointServiceConfiguration ASAP.

Thank you all, and I look forward to receiving feedback on this PR!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

---

Full context

• feat(VpcEndpointServiceConfiguration): vpc endpoint service configuration controller added #134
  • The original PR that added support for VPC endpoint services to ec2-controller. It seemed to be blocked pending a code-gen issue.
• Error while generator controller references within lists inside lists aren't supported. crd: "RouteTable", path: "Routes.GatewayID" community#1718
  • The issue allegedly blocking the aforementioned PR from being merged. AFAICT, it had something to do with nested list structures.

---

It is by no means my intention to remove any credit from @ib-ak for this work! GitHub's WYSIWYG editor won't seem to let me tag them, but I hope it is working ☹️. As soon as I type the "dash" in that username, the automatic username suggestions disappear.

[ack-prow]

Hi @cannonpalms. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cannonpalms
Once this PR has been reviewed and has the lgtm label, please assign vijtrip2 for approval by writing /assign @vijtrip2 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[a-hilaly]

Thank you @cannonpalms - overall this looks good!

I have few comments bellow.

[a-hilaly]

We need to regenerate the controller using latest commit of code-generator

[a-hilaly]

where is addIDToDeleteRequest function defined? typical we add custom functions to a file called hooks.go

[a-hilaly]

I this that this template only generated newTag, is it intended?

[a-hilaly]

Since this controller is already GA, we will need e2e tests for each new resource.

[cannonpalms]

Thank you @a-hilaly for engaging with this PR and providing reviews. I regret to have to tell you that we ended up straying away from ACK for managing our VPCEndpointServices, and lack the bandwidth to give this PR the attention that it requires for landing.

I do hope that someone takes up the mantle of aws-controllers-k8s/community#1711 (which, as a side note, has been closed as stale--perhaps that issue should be /lifecycle frozen?). It is a much needed feature!