Correctly handle watchNamespace flag parsing errors #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we shipped a feature (d3b23cd) where multi-namespace watch mode was supported. It turns out that the logic was completely flipped. We need to assign namespace when the error is NIL and not vice versa. If the error is NOT NIL, we need to block the controller initiation and throw an error. How did we catch this? Nothing special, just reviewing the generated code and asking who on earth wrote that. This indeed urges us to do proper CARM/multi-namespace/cross-region testing and write some e2e tests that we can catch very early on. When code-generator PRs are drafted. The current infra doesn't allow us to that, so we'll hack something around next week. Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
multinamespace
branch
from
d37baba to
bea1c54
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we shipped a feature (d3b23cd) where multi-namespace watch
mode was supported. It turns out that the logic was completely flipped.
We need to assign namespace when the error is NIL and not vice versa. If
the error is NOT NIL, we need to block the controller initiation and
throw an error.
How did we catch this? Nothing special, just reviewing the generated
code and asking who on earth wrote that (me).
This indeed urges us to do proper
CARM/multi-namespace/cross-regiontesting and write some e2e tests that we can catch these issue very early on ...
When the
code-generatorPRs are drafted.The current infra doesn't allow us to that, so we'll hack something
around next week.
Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.