Skip to content

Add support for injecting custom fields of type bytes #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ack-prow merged 1 commit into from
Jan 17, 2024
Merged

Add support for injecting custom fields of type bytes #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/model/sdk_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ var (
"string": "string",
"bool": "boolean",
"time.Time": "timestamp",
"bytes": "blob",
}
)

Expand Down Expand Up @@ -140,7 +141,7 @@ func (a *SDKAPI) GetShapeRefFromType(
// first check to see if the element type is a scalar and if it is, just
// create a ShapeRef to represent the type.
switch elemType {
case "string", "bool", "int", "int64", "float64", "time.Time":
case "string", "bool", "int", "int64", "float64", "time.Time", "bytes":
sdkType, found := GoTypeToSDKShapeType[elemType]
if !found {
msg := fmt.Sprintf("GetShapeRefFromType: unsupported element type %s", elemType)
Expand Down