Enhance resource comparison for collections and blobs #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack-prow
bot
added
the
do-not-merge/work-in-progress
Member
Author
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
This update enhances the logic for comparing resources in code generation, especially for collections (maps and arrays) and blob types. The previous method used nil checks, but they weren't helpful for these types. The revised code introduces a new function, `fastCompareTypes`, to generate Go code that quickly compares two objects of the same type. For collections, it uses the built-in `len` function to swiftly spot length differences before diving into detailed checks. For blobs, the code now employs the `bytes.Equal` function for straightforward byte array comparisons. This enhancement aims to make the generated comparison logic more direct, readable, and efficient, especially when dealing with collections and blobs in AWS SDK shapes. Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
delta-collections
branch
from
1fa2f17 to
ad5ccd5
Compare
a-hilaly
changed the title
ack-prow
bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/retest |
ivelichkovich
approved these changes
Dec 13, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ivelichkovich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances the logic for comparing resources in code
generation, especially for collections (maps and arrays) and blob
types. The previous method used nil checks, but they weren't
helpful for these types.
The revised code introduces a new function,
fastCompareTypes,to generate Go code that quickly compares two objects of the same
type. For collections, it uses the built-in
lenfunction toswiftly spot length differences before diving into detailed checks.
For blobs, the code now employs the
bytes.Equalfunction forstraightforward byte array comparisons.
This enhancement aims to make the generated comparison logic more
direct, readable, and efficient, especially when dealing with
collections and blobs in AWS SDK shapes.
Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.