Adding functionality to assign whole object to a field #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/retest |
a-hilaly
reviewed
May 26, 2023
Comment on lines
+223
to
+225
| if path == "." { | ||
| return &op.InputRef, true | ||
| } |
Member
There was a problem hiding this comment.
Can we have a unit test for this?
Edit: it might be complex as we don't have unit test for api types generation...
a-hilaly
approved these changes
May 26, 2023
Member
a-hilaly
left a comment
a-hilaly
left a comment
There was a problem hiding this comment.
Happy to ship test if e2e tests pass
Member
RedbackThomson
approved these changes
Jun 1, 2023
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This PR is created to support the code-generation for
FunctionEventInvokeConfigfeature in lambda-controller. PR#92Description of changes:
This PR adds functionality to assign whole object to a field, instead of assigning a particular parameter of it. To clarify it further, in the below code, we created a new field
LayerStatuseswhich stores the value ofConfiguration.Layersparameter taken fromGetFunctionoperation.In our case we needed to add
FunctionEventInvokeConfigas an inline property toFunctionresource, for which we needed to assign the whole object returned byPutFunctionEventInvokeConfigoperation to fieldFunctionEventInvokeConfig. To make this work we added a new condition for it by passingpathvalue as., shown below:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.