-
Notifications
You must be signed in to change notification settings - Fork 235
chore: Fix spelling errors #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @candrews. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jljaco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to ignore anything under pkg/testdata as this is bulk imported from an external source.
Spell checking done using codespell. Correct spelling is a great way to look more professional and demonstrate higher quality. And it catches a surprisingly number of actual errors, too. Signed-off-by: Craig Andrews <[email protected]>
Done! 👍 |
jaypipes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @candrews! :)
|
/lgtm |
| "RegisterApplicationRevision": "<p>Registers with AWS CodeDeploy a revision for the specified application.</p>", | ||
| "RegisterOnPremisesInstance": "<p>Registers an on-premises instance.</p> <note> <p>Only one IAM ARN (an IAM session ARN or IAM user ARN) is supported in the request. You cannot use both.</p> </note>", | ||
| "RemoveTagsFromOnPremisesInstances": "<p>Removes one or more tags from one or more on-premises instances.</p>", | ||
| "SkipWaitTimeForInstanceTermination": "<p>In a blue/green deployment, overrides any specified wait time and starts terminating instances immediately after the traffic routing is complete.</p>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're actually finding spelling mistakes in official AWS models. Sounds like we need this tool to run internally, too. 😆
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candrews, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Spell checking done using codespell.
Correct spelling is a great way to look more professional and demonstrate higher quality. And it catches a surprisingly number of actual errors, too.
Following up on aws-controllers-k8s/iam-controller#78
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.