Pin ACK runtime to v0.25.0
#432
Conversation
|
/retest |
RedbackThomson
force-pushed
the
release-0.25.0
branch
from
b879fb8 to
4ef5026
Compare
pkg/generate/ack/runtime_test.go
Outdated
|
|
||
| type fakeDescriptor struct{} | ||
|
|
||
| func (fd *fakeDescriptor) GroupKind() *metav1.GroupKind { |
There was a problem hiding this comment.
Does this change belong in this PR?
There was a problem hiding this comment.
I suppose this is a miss from my previous PR. Want me to split this out and merge separately?
RedbackThomson
force-pushed
the
release-0.25.0
branch
from
acd1db0 to
4ef5026
Compare
RedbackThomson
force-pushed
the
release-0.25.0
branch
from
4ef5026 to
6f95b4c
Compare
|
@RedbackThomson: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jljaco
left a comment
jljaco
left a comment
There was a problem hiding this comment.
looks good. happy to /lgtm once these tests pass (pending a fix in a different PR)
That PR has already been merged and this PR rebased on top of it |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description of changes:
Updates the ACK runtime version in
go.modtov0.25.0By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.