Skip to content

Conversation

@jljaco
Copy link
Contributor

@jljaco jljaco commented Mar 14, 2023

Issue #, if available:

Description of changes:
A small quality-of-life improvement for e2e testing workflow when running on a Mac. Currently, when one isn't logged into public.ecr.aws, you get the following when trying to run make kind-test:

10:36 $ make kind-test                                                                                                                                                                                                                                                    
2023-03-14T10:36:45 [DEBUG] Debug mode enabled                                                                                                                                                                                                                            
...
2023-03-14T10:36:47 [INFO] Building controller image ...                                                                                                                                                                                                                  
cut: stdin: Illegal byte sequence 

This change breaks one command pipeline (jq + base64 + cut + base64 + jq) into two chunks so that we can check the value returned by the first jq call to see if it's null, and exit 1 if so.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from RedbackThomson and a-hilaly March 14, 2023 17:57
@ack-prow ack-prow bot added the approved label Mar 14, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 14, 2023

@jljaco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 88896b8 link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah nice
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@jaypipes
Copy link
Collaborator

/lgtm

@ack-prow
Copy link

ack-prow bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, jljaco, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,jaypipes,jljaco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RedbackThomson RedbackThomson merged commit 0888419 into aws-controllers-k8s:main Mar 14, 2023
RedbackThomson pushed a commit to RedbackThomson/ack-code-generator that referenced this pull request Mar 21, 2023
…all (aws-controllers-k8s#428)

* QIL improvement to common.sh: check for null return status from ECR call

* Simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants