Add 404: ResourceError handling in sdkFind#421
Add 404: ResourceError handling in sdkFind#421RedbackThomson merged 1 commit intoaws-controllers-k8s:mainfrom
404: ResourceError handling in sdkFind#421Conversation
| if err != nil { | ||
| if reqErr, ok := ackerr.AWSRequestFailure(err); ok && reqErr.StatusCode() == 404 { | ||
| return nil, ackerr.NotFound | ||
| + } |
There was a problem hiding this comment.
There was a problem hiding this comment.
i meant + 👁️ , there is a tiny extra character in the last line :)
There was a problem hiding this comment.
Intentation is correct, but there was a little + copied from my git patch foo, well spotted @a-hilaly !
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
|
@embano1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a-hilaly
left a comment
a-hilaly
left a comment
There was a problem hiding this comment.
It's funny that AWSRequestFailure already exists in runtime :)
Looks good to me! We can force merge as the prow errors are not related to this change.
Danke Michael!
|
Can someone please force-merge to get this PR closed :) 🙏🏻 |
RedbackThomson
changed the title
404 ResourceError` handling in sdkFind404: ResourceError handling in sdkFind
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, embano1, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
In the
Pipesservice controller we noticed that the error returned from the API is of typeRequestFailure. A workaround is to setcode: ""ingenerator.yamlor for those not aware of this issue fallback using this new type assertion inREAD_ONE.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.