chore(analytics): Simplify error code checking, uniformly across platforms #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhuka
reviewed
Feb 3, 2023
...oint/src/main/java/com/amazonaws/mobileconnectors/pinpoint/internal/event/EventRecorder.java
Show resolved
Hide resolved
mattcreaser
approved these changes
Feb 8, 2023
sdhuka
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter team asked Pinpoint about error codes and discovered that any event with a status code of 5xx can be retried. Checking specifically for exception names may be deprecated if they decide to add additional exception types, but they will maintain that 5xx error codes can be retried going forward. Matching PR on Amplify v2 here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.