fix(pinpoint): Fix Pinpoint NullPointerException #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
div5yesh
approved these changes
Sep 17, 2022
sktimalsina
changed the title
sktimalsina
changed the title
sktimalsina
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3001 hopefully!
Bug: when using reflection, if the first round of class instantiation (
initClassAndMethodsByReflection()) goes successfully but then the second round fails (buildMethodsByReflection()), future calls tocreateNotification()will incorrectly believe that the entire reflection process resolved and attempt to use the invalid methods.Fix: set
notificationBuilderClassback tonullif the process doesn't work at any stage, so it won't skip. Also added NPEcatchblocks just in case.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.