-
Notifications
You must be signed in to change notification settings - Fork 340
Verify user flow #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Verify user flow #196
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a91634c
feat: adding verify user flow
f63254e
Merge branch 'main' into verify-user-flow
c3760a3
add tests for verify user and setup i18n in all react environments
9b06e4e
updating tests yml with new env variable
d2980c0
Merge branch 'main' into verify-user-flow
eddiekeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
examples/next/pages/ui/components/authenticator/sign-up/index.page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,13 @@ | ||
| import { Authenticator } from '@aws-amplify/ui-react'; | ||
| import { Amplify } from 'aws-amplify'; | ||
| import { dict } from '@aws-amplify/ui-core'; | ||
| import { Amplify, I18n } from 'aws-amplify'; | ||
|
|
||
| import awsExports from '@environments/auth-with-username-no-attributes/src/aws-exports'; | ||
|
|
||
| Amplify.configure(awsExports); | ||
|
|
||
| I18n.putVocabularies(dict); | ||
|
|
||
| export default function AuthenticatorWithUsername() { | ||
| return <Authenticator />; | ||
| } |
5 changes: 4 additions & 1 deletion
5
examples/next/pages/ui/components/authenticator/withAuthenticator/index.page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/e2e/cypress/integration/ui/components/authenticator/verify-user.feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| Feature: Verify User | ||
|
|
||
| Amplify's SignIn component uses AWS Cognito's authentication | ||
| service to provide a sign in experience to your application's | ||
| users. | ||
|
|
||
| Background: | ||
| Given I'm running the example "ui/components/authenticator/sign-in-federated" | ||
|
|
||
| @next @react | ||
| Scenario: Verify User with valid but unverified email | ||
| When I type a valid but unverified email "UNVERIFIED_EMAIL" | ||
| And I type a valid password "VALID_PASSWORD" | ||
| And I click the "Sign in" button | ||
| Then I will be redirected to the verify user page | ||
| And I click on the first radio button | ||
| And I click the "Verify" button | ||
| Then I will be redirected to the confirm verify user page |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
aws-amplify-reactpackage, we do this call ourselves when exporting the modules: https://github.com/aws-amplify/amplify-js/blob/main/packages/aws-amplify-react/src/index.tsx#L30Is this something we expect customers to do in their applications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, yes. Because this might look different in React vs Angular vs Vue. Suggestion proposed by Eric on my last PR - #189 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this to be in https://github.com/aws-amplify/amplify-ui/blob/verify-user-flow/examples/next/pages/_app.tsx since most examples need it?