Use common button click step and make it case insensitive #194
Conversation
|
This pull request introduces 1 alert when merging 007b63b into a862b9d - view on LGTM.com new alerts:
|
| And I don't see "Phone Number" as an input field | ||
|
|
||
| @next @react @vue @angular | ||
| @next @react @vue @angular @skip |
There was a problem hiding this comment.
This test is leading us to Exceeded daily email limit for the operation or the account. If a higher limit is required, please configure your user pool to use your own Amazon SES configuration for sending email.
There was a problem hiding this comment.
We need to contact the SES team to escalate this so we can get our account out of the SES sandbox. I agree with skipping for now
There was a problem hiding this comment.
@eddiekeller Didn't you experience this as well & request an increase?
There was a problem hiding this comment.
@ericclemmons The workaround is to switch to using our own email in Amazon SES rather than relying on Cognito to send out emails for us. Not sure if that is what we want to use long term or not.
|
|
||
| And('I click the {string} button', (name: string) => { | ||
| cy.findByRole('button', { name }).click(); | ||
| When('I click the {string} button', (name: string) => { |
There was a problem hiding this comment.
This step definition can be used by any test, so I just updated this one to be case insensitive so all tests can use this.
| And I don't see "Phone Number" as an input field | ||
|
|
||
| @next @react @vue @angular | ||
| @next @react @vue @angular @skip |
There was a problem hiding this comment.
We need to contact the SES team to escalate this so we can get our account out of the SES sandbox. I agree with skipping for now
Update version and use AmplifyProvider
4 participants
Issue #, if available: N/A
Description of changes: With the introduction of I18N strings in authenticator (PR 189), we need the common "Click button" Cypress action to be case insensitive to function correctly with the new strings.
Furthermore, I'm skipping the "Sign up with valid email & password" test in
sign-up-with-email.feature. We continuously get a failure due toExceeded daily email limit for the operation or the account. If a higher limit is required, please configure your user pool to use your own Amazon SES configuration for sending email.This will be addressed as part of my audit of skipped e2e tests (Asana), but it makes the most sense right now to skip so CI can continue to function correctly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.