-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resolve SwiftFormat errors and warnings at the categories module #3843
chore: resolve SwiftFormat errors and warnings at the categories module #3843
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore/resolve_swiftformat #3843 +/- ##
=============================================================
- Coverage 68.51% 68.40% -0.11%
=============================================================
Files 1080 1080
Lines 37608 37747 +139
=============================================================
+ Hits 25766 25821 +55
- Misses 11842 11926 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
There's still a bunch of SwiftLint errors through the code. GitHub doesn't let me add comments on them because no line was changed, but we should either add // swiftlint:disable <rule>
statements or fix them.
@@ -80,8 +88,8 @@ extension AuthCategory: AuthCategoryBehavior { | |||
} | |||
|
|||
public func confirmResetPassword( | |||
for username: String, with | |||
newPassword: String, | |||
for username: String, with newPassword: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for username: String, with newPassword: String, | |
for username: String, | |
with newPassword: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Issue #
Description
Resolving SwiftFormat errors and warnings for the Amplify categories module.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.