Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular doc update #866

Merged
merged 7 commits into from
May 29, 2018
Merged

angular doc update #866

merged 7 commits into from
May 29, 2018

Conversation

haverchuck
Copy link
Contributor

*Issue #, if available:
Addresses #678

*Description of changes:
Gives some context and a workaround for the Angular 6 global shim issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dkocich added a commit to dkocich/osm-pt-ngx-leaflet that referenced this pull request May 19, 2018
dkocich added a commit to dkocich/osm-pt-ngx-leaflet that referenced this pull request May 20, 2018
@manueliglesias manueliglesias self-requested a review May 22, 2018 19:00
@codecov-io
Copy link

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #866   +/-   ##
======================================
  Coverage    87.5%   87.5%           
======================================
  Files          78      78           
  Lines        3713    3713           
  Branches      710     710           
======================================
  Hits         3249    3249           
  Misses        441     441           
  Partials       23      23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9287da1...96430a3. Read the comment docs.

@haverchuck haverchuck merged commit 202b865 into aws-amplify:master May 29, 2018
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants