-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Vite Bundle Size Action Example Demonstrating Vite Errors with library #7970
Conversation
We want to ensure we continue running against the newest versions, like customers do
"@vitejs/plugin-vue": "^1.1.5", | ||
"@vue/compiler-sfc": "^3.0.5", | ||
"vite": "^2.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this use latest
? I don't know how this project is initialized, so I'm uncertain if these are latest
, next
, or specifically defined from some external docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what's configured after a yarn create @vitejs/app
This pull request introduces 3 alerts when merging de50adb into 492f925 - view on LGTM.com new alerts:
|
if(global === undefined){ | ||
global = window; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn dev
initially failed for me, then I changed this to:
<script>
// https://docs.amplify.aws/start/getting-started/setup/q/integration/angular#angular-6-support
window.global = window;
</script>
Now yarn dev
works! But yarn build
still fails...
Codecov Report
@@ Coverage Diff @@
## main #7970 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 215 215
Lines 13473 13473
Branches 2646 2646
=======================================
Hits 10004 10004
Misses 3271 3271
Partials 198 198
Continue to review full report at Codecov.
|
So we learned the following:
My question is, how can we or |
This pull request introduces 3 alerts when merging 468a14c into 5af2e1a - view on LGTM.com new alerts:
|
I have uploaded a newer work around, that should allow amplify to work with Vite. See -> https://github.com/aws-amplify/amplify-js/issues/7499#issuecomment-804386820 |
This pull request introduces 2 alerts when merging 0ac0dc6 into 2b800f5 - view on LGTM.com new alerts:
|
No longer needed, I'll close this. |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This PR is demonstrate the errors with Vite when running with the amplify-js library.
Description of changes
This adds a Vite app to the bundle-size action directory
Issue #, if available
The errors are seen in #7499
Description of how you validated changes
To reproduce, run
yarn dev
.Or
yarn build