Skip to content

Conversation

@iartemiev
Copy link
Member

Addresses this part of the feature request for adding web worker support for DataStore. The other part was added in #6874

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #6956 into main will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6956      +/-   ##
==========================================
- Coverage   73.29%   73.27%   -0.02%     
==========================================
  Files         213      213              
  Lines       13190    13192       +2     
  Branches     2486     2487       +1     
==========================================
  Hits         9667     9667              
- Misses       3359     3361       +2     
  Partials      164      164              
Impacted Files Coverage Δ
packages/core/src/Util/Reachability.ts 32.14% <25.00%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe328ee...0acce29. Read the comment docs.

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iartemiev iartemiev merged commit ebb20c1 into aws-amplify:main Oct 13, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants