fix(@aws-amplify/pubsub): Block subscriptions for SSR, not Node #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
commented
Oct 8, 2020
| @@ -1,24 +0,0 @@ | |||
| jest.mock('@aws-amplify/core', () => ({ | |||
Contributor
Author
There was a problem hiding this comment.
This was actually renamed to .ssr.ts, but showing as a deletion 🤷
|
This pull request introduces 1 alert when merging 1d84b07 into 53be43d - view on LGTM.com new alerts:
|
manueliglesias
approved these changes
Oct 8, 2020
Contributor
manueliglesias
left a comment
manueliglesias
left a comment
There was a problem hiding this comment.
LGTM Thanks @ericclemmons !
iartemiev
pushed a commit
that referenced
this pull request
Oct 13, 2020
ericclemmons
added a commit
to ericclemmons/amplify-js
that referenced
this pull request
Nov 19, 2020
Partial revert of aws-amplify#6937 to ensure that subscriptions still work on the client.
2 tasks
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #6873
#6146 & #6726 blocked
PubSub.subscribefrom being used in Node environments for security reasons (multi-tenant requests sharing the same socket), butisNodeisn't a reliable indicator of that usage:ssr: trueis.isNodeis a valid runtime for single-tenant environments, such as Electron.This PR improves the specificity of the
PubSub.subscribecheck to match the use-case it was designed for (SSR) vs. blocking legitimate usages of sockets.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.