Skip to content

Conversation

@iartemiev
Copy link
Member

@iartemiev iartemiev commented Oct 1, 2020

Just some minor improvements:

  • Generate and store yarn.lock as an artifact (then delete it from source)
    • This will allow us to more easily debug dependency-related build issues by diff'ing against the lockfile from the last known working build. We've spent entire days simply trying to pinpoint which upstream dependency got updated with breaking changes. This should expedite that process if it happens again.
  • Remove save_cache/restore_cache steps for CocoaPods in RN integ test jobs. More trouble than it's worth, causes issues when RN itself and RN-deps are upgraded in the sample apps.
  • Upgrade the macOS executor to XCode 11.5.0 (this is the latest we can use until we upgrade our Android emulator)
  • Test run for pipeline changes: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/6296/workflows/7ba7fbe0-22f7-460a-a962-7f61906ee7c5

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #6895 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6895   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files         213      213           
  Lines       13191    13191           
  Branches     2582     2582           
=======================================
  Hits         9668     9668           
  Misses       3329     3329           
  Partials      194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880e1da...2f68a03. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Comment on lines +271 to +274
# storing yarn.lock as an artifact, so that we can quickly get a dependency diff
# with the last working build in the event that some upstream deps break the build in the future
- store_artifacts:
path: yarn.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@iartemiev iartemiev merged commit 16aaa05 into main Oct 1, 2020
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
iartemiev added a commit that referenced this pull request Oct 13, 2020
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
@jimblanc jimblanc deleted the test-detox-update branch November 23, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants