fix(@aws-amplify/datastore): check for token before getting payload #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iartemiev
approved these changes
Sep 30, 2020
Codecov Report
@@ Coverage Diff @@
## main #6893 +/- ##
==========================================
- Coverage 73.29% 73.29% -0.01%
==========================================
Files 213 213
Lines 13190 13191 +1
Branches 2485 2486 +1
==========================================
Hits 9668 9668
- Misses 3358 3359 +1
Partials 164 164
Continue to review full report at Codecov.
|
nubpro
pushed a commit
to nubpro/amplify-js
that referenced
this pull request
Oct 2, 2020
…ws-amplify#6893) * check for token before getting payload
iartemiev
pushed a commit
that referenced
this pull request
Oct 13, 2020
…6893) * check for token before getting payload
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When checking for the OIDC token, running
token.splitcauses a console warning to show whentokendoesn't exist. This didn't impact any functionality and only caused a console warning to show, but this PR will add a conditional check before attempting tosplit.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.