fix: Add files with Amplify.register to sideEffects array #6867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manueliglesias
requested review from
elorzafe,
ericclemmons and
sammartinez
Codecov Report
@@ Coverage Diff @@
## main #6867 +/- ##
=======================================
Coverage 73.34% 73.34%
=======================================
Files 212 212
Lines 13146 13146
Branches 2470 2566 +96
=======================================
Hits 9642 9642
+ Misses 3340 3310 -30
- Partials 164 194 +30
Continue to review full report at Codecov.
|
Contributor
https://github.com/aws-amplify/amplify-js-samples-staging/tree/master/samples/next/auth/ssr-auth
|
ericclemmons
approved these changes
Sep 24, 2020
Contributor
ericclemmons
left a comment
ericclemmons
left a comment
There was a problem hiding this comment.
Next.js no changes, CRA +455B.
Contributor
|
Testing a predictions and graphql vue sample I have. Chunks using Chunks using |
ashika01
approved these changes
Sep 24, 2020
Contributor
|
@Amplifiyer's sample app with |
Contributor
|
@aws-amplify/interactions with Angular prod is working fine too. Computing the diff now... edit: tested on react / vue and they are good 👍 react diff: my chatbot samples seem to have larger diffs, but this maybe something on ui-component/chatbot side (as it already has a large bundle size to start with). Let's see what others get first. |
wlee221
approved these changes
Sep 24, 2020
amhinson
approved these changes
Sep 24, 2020
elorzafe
approved these changes
Sep 24, 2020
Contributor
elorzafe
left a comment
elorzafe
left a comment
There was a problem hiding this comment.
Thanks @manueliglesias ! 🥇
nubpro
pushed a commit
to nubpro/amplify-js
that referenced
this pull request
Oct 2, 2020
iartemiev
pushed a commit
that referenced
this pull request
Oct 13, 2020
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to #6844
Description of changes:
This PR adds files that call
Amplify.configure()to the"sideEffects"key inpackage.json.The purpose of this is to hint bundlers to not remove the categories registration when creating the bundle.
Tests were done with an angular 9 application in production mode using
@aws-amplify/authBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.