-
Notifications
You must be signed in to change notification settings - Fork 2.2k
bugfix #5218: de/encode custom state using base16 #6851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix #5218: de/encode custom state using base16 #6851
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6851 +/- ##
==========================================
- Coverage 73.48% 73.35% -0.13%
==========================================
Files 205 213 +8
Lines 12621 13153 +532
Branches 2460 2566 +106
==========================================
+ Hits 9275 9649 +374
- Misses 3157 3310 +153
- Partials 189 194 +5
Continue to review full report at Codecov.
|
ericclemmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @div5yesh! I'm ready to approve, but would want to see a couple tests validating this since we ran into interesting behavior.
unit tests for url safe encoding/decoding
ericclemmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
The only concern I have is if this patch release will break existing IE 11 apps due to the use of TextEncoder.
IE 11 usage requires a good deal of polyfills by customers today, so needing a polyfill won't be new, but I'd like to also avoid breaking their apps the next time they npm install.
If we're already using TextEncoder elsewhere, I think we're good! Otherwise, are we converting strings to streams differently? (This implementing looks like what we needed to re-use toHex/fromHex)
@elorzafe What are your thoughts?
elorzafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @div5yesh ! 👍 🌮 🎉
…lify#6851) * bugfix aws-amplify#5218: de/encode custom state using base16 * use aws-sdk hex encoding util unit tests for url safe encoding/decoding * avoid using TextEncoder to support IE11 Co-authored-by: Sam Martinez <samlmar@amazon.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: #5218
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.